-
Notifications
You must be signed in to change notification settings - Fork 2
Prod release #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Prod release #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We expect that styles and scripts rendered in the admin dashboard will not be filterable, so only supply a CSP for the front-end.
So we can use it with a CSP.
And add a nonce to all enqueued scripts.
In preparation for removing gravatar.com from the CSP.
Chore/tighten content security policy
Make addContentSecurityPolicy solely responsible for deciding when to add a CSP to a page. Applies SRP.
Previously a bug in the implementation of is_login() caused
CSPs to be omitted for any page which partially matched the
path '/wp-login.php' including '/'.
Now, we work around that by checking SCRIPT_NAME in the
superglobal directly.
See:
https://core.trac.wordpress.org/ticket/63896#ticket
Fix/front page should have csp
leedxw
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tighten the CSP so that
src-scriptsno longer hasunsafe-inlinebut instead validates a nonce on every script.