feat: add optional port binding, alter ui validation #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot9706
reviewed
Jan 27, 2023
m8vago
approved these changes
Jan 28, 2023
polaroi8d
approved these changes
Jan 30, 2023
efbfb42 to
b05156f
Compare
Codecov ReportBase: 17.92% // Head: 17.97% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## develop #444 +/- ##
===========================================
+ Coverage 17.92% 17.97% +0.04%
===========================================
Files 57 57
Lines 5951 5965 +14
===========================================
+ Hits 1067 1072 +5
- Misses 4809 4818 +9
Partials 75 75
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
b05156f to
22b1269
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host binding was inevitable until this change, with this user can expose ports without binding them to host.
The validation was strict on the UI that was lifted, external port can be left empty now, dagent adds these ports to the exposed ports but not the NAT'd ports list.
Regarding crane this is out of question, portbindings are straight-up ignored.