Skip to content

fix: minor ui fixes & dagent image url parsing #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robot9706 merged 2 commits into from
Feb 14, 2023
Merged

fix: minor ui fixes & dagent image url parsing #456

robot9706 merged 2 commits into from
Feb 14, 2023

Conversation

@robot9706
Copy link
Contributor

@robot9706 robot9706 commented Feb 8, 2023

  • Added option to pass an image URI object to the container builder: this fixes an issue when checking if the image exists locally (the whole name was checked, but in case of 'docker.io/library' images, this doesn't work)

  • Fixed the default deployment prefix: dots and upper case characters where not handled correctly.

  • Fixed an issue where opening any version or deployment shows errors when using unchecked registries.

@robot9706 robot9706 added issue:improvement Issue that makes something better. source:agent The scope of the issue or pull request is agent. source:web The scope of the issue or pull request is web. pr:fix pr:refactor lang:golang lang:typescript labels Feb 8, 2023
@robot9706 robot9706 self-assigned this Feb 8, 2023
@m8vago m8vago marked this pull request as ready for review February 10, 2023 10:51
@m8vago m8vago requested a review from a team as a code owner February 10, 2023 10:51
@robot9706 robot9706 mentioned this pull request Feb 10, 2023
Merged
m8vago
m8vago approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@m8vago m8vago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed ts only

nandor-magyar
nandor-magyar requested changes Feb 10, 2023
View reviewed changes
nandor-magyar
nandor-magyar reviewed Feb 13, 2023
View reviewed changes
Copy link
Contributor

@nandor-magyar nandor-magyar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error handling will be moved into Create in the builder, we wait for that now.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023 •
edited
Loading

Codecov Report

Base: 17.92% // Head: 17.65% // Decreases project coverage by -0.28% ⚠️

Coverage data is based on head (fe73e0e) compared to base (adcc0ac).
Patch coverage: 23.26% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #456      +/-   ##
===========================================
- Coverage    17.92%   17.65%   -0.28%     
===========================================
  Files           57       57              
  Lines         5981     6056      +75     
===========================================
- Hits          1072     1069       -3     
- Misses        4834     4905      +71     
- Partials        75       82       +7
Impacted Files Coverage Δ
golang/internal/grpc/grpc.go 0.00% <0.00%> (ø)
golang/internal/mapper/grpc.go 68.68% <0.00%> (-0.74%) ⬇️
golang/pkg/cli/config_file.go 0.00% <0.00%> (ø)
golang/pkg/cli/runner.go 0.00% <0.00%> (ø)
golang/pkg/crane/k8s/deploy_facade.go 0.00% <0.00%> (ø)
golang/pkg/crane/k8s/deployment.go 13.54% <0.00%> (ø)
golang/pkg/dagent/update/update.go 0.00% <0.00%> (ø)
golang/pkg/dagent/utils/container.go 0.00% <0.00%> (ø)
golang/pkg/dagent/utils/docker.go 10.74% <0.00%> (+0.01%) ⬆️
golang/pkg/dagent/utils/import_container.go 13.04% <0.00%> (-0.60%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

nandor-magyar
nandor-magyar reviewed Feb 13, 2023
View reviewed changes
@robot9706 robot9706 force-pushed the fix/ui-dagent-fixes branch 3 times, most recently from 201d3b6 to a04c0e1 Compare February 13, 2023 15:13
nandor-magyar
nandor-magyar reviewed Feb 13, 2023
View reviewed changes
nandor-magyar
nandor-magyar approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@nandor-magyar nandor-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robot9706 robot9706 merged commit b478f86 into develop Feb 14, 2023
@robot9706 robot9706 deleted the fix/ui-dagent-fixes branch February 14, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m8vago m8vago m8vago approved these changes

@nandor-magyar nandor-magyar nandor-magyar approved these changes

Assignees

@robot9706 robot9706

Labels

issue:improvement Issue that makes something better. lang:golang lang:typescript pr:fix pr:refactor source:agent The scope of the issue or pull request is agent. source:web The scope of the issue or pull request is web.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@robot9706 @codecov-commenter @m8vago @nandor-magyar