Skip to content

fix: proto makefile does not work on windows #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robot9706 merged 2 commits into from
Jul 28, 2022
Merged

fix: proto makefile does not work on windows #52

robot9706 merged 2 commits into from
Jul 28, 2022

Conversation

@robot9706
Copy link
Contributor

@robot9706 robot9706 commented Jul 28, 2022

No description provided.

@robot9706 robot9706 requested a review from a team July 28, 2022 08:27
@robot9706 robot9706 marked this pull request as ready for review July 28, 2022 08:27
polaroi8d
polaroi8d requested changes Jul 28, 2022
View reviewed changes
polaroi8d
polaroi8d approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

balanceee
balanceee approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@balanceee balanceee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robot9706 robot9706 merged commit 695e1d1 into develop Jul 28, 2022
@robot9706 robot9706 deleted the fix/protogen-win branch July 28, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polaroi8d polaroi8d polaroi8d approved these changes

+1 more reviewer

@balanceee balanceee balanceee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@robot9706 @polaroi8d @balanceee