refactor(agent): move container builder to package #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d681431 to
48fc289
Compare
ef94e69 to
8e179c6
Compare
polaroi8d
reviewed
Aug 8, 2022
Collaborator
|
Not part of the task, but could you extend it with godoc and unit tests? |
Codecov Report
@@ Coverage Diff @@
## develop #65 +/- ##
==========================================
+ Coverage 5.18% 9.58% +4.39%
==========================================
Files 58 60 +2
Lines 4185 4268 +83
==========================================
+ Hits 217 409 +192
+ Misses 3964 3830 -134
- Partials 4 29 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nandor-magyar
approved these changes
Aug 9, 2022
Contributor
nandor-magyar
left a comment
There was a problem hiding this comment.
It grows and evolves. 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved container builder to a separate package so it could be used independetly from agent packages.
Also ran
gofmt.Depends on: #61