fix(web): ws-hook universal error handler #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polaroi8d
approved these changes
Aug 18, 2022
Collaborator
polaroi8d
left a comment
There was a problem hiding this comment.
Is this solve that the platform shows error messages multiple times? LGTM (informal) but please wait for others with the merge.
Contributor
Author
@polaroi8d Yep. I'd also like @m8vago to check as well :) |
m8vago
reviewed
Aug 18, 2022
m8vago
reviewed
Aug 18, 2022
m8vago
reviewed
Aug 18, 2022
m8vago
reviewed
Aug 22, 2022
m8vago
approved these changes
Aug 22, 2022
fix(web): ws-hook single toast error handler fix: formatting fix(crux-ui): changed useWebSocket hook translation fix(crux-ui): moved ws to provider
f0d8406 to
250c1e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WS_TYPE_DYO_ERRORwas handled multiple times by showing a toast, pages which use multipleuseWebSockethooks show multiple toasts.Implemented a universal error handler in
WebSocketClientwhich shows the toast, pages can still do their error handling logic usingWS_TYPE_DYO_ERROR.Added a WebSocket provider to create the socket only once.