feat: agent install name #1016
Merged
feat: agent install name #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The same collision is true for crane as well. The name |
c0446a3 to
38a4ab1
Compare
m8vago
requested changes
Nov 25, 2024
38d5b11 to
fa719c7
Compare
fa719c7 to
1b66090
Compare
polaroi8d
requested changes
Nov 27, 2024
Collaborator
There was a problem hiding this comment.
Please implement a container name validation, in the UI.
After naming the agent to: teszting 0001 ?#@$_+)!@31 , got the following command after running the curl command:
docker: Error response from daemon: Invalid container name (teszting 0001 ?#@$_+)!@31 ), only [a-zA-Z0-9][a-zA-Z0-9_.-] are allowed.
a62e814 to
f739bfd
Compare
m8vago
approved these changes
Nov 28, 2024
polaroi8d
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the option to change the container name of dagent, to avoid name collision when installing multiple agents on the same node.