Skip to content

Conversation

@robot9706
Copy link
Contributor

Add a column which shows the order of the images.

Fixed an issue with image orders using 0 and 1 as the base index depending on how it's edited.

@robot9706 robot9706 self-assigned this Nov 26, 2024
@github-actions github-actions bot added source:web The scope of the issue or pull request is web. lang:typescript lang:sql pr:feat labels Nov 26, 2024
@robot9706 robot9706 marked this pull request as ready for review November 26, 2024 15:06
@robot9706 robot9706 requested a review from a team as a code owner November 26, 2024 15:06
@robot9706 robot9706 force-pushed the feat/image-order-column branch from d845a7c to e375ba6 Compare November 26, 2024 15:07
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have only one image, it will start with #2. That’s not good.

@robot9706 robot9706 requested a review from polaroi8d November 27, 2024 12:46
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine after the prisma migrate.

@polaroi8d polaroi8d merged commit c41d5a2 into develop Nov 27, 2024
26 checks passed
@polaroi8d polaroi8d deleted the feat/image-order-column branch November 27, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang:sql lang:typescript pr:feat source:web The scope of the issue or pull request is web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants