Skip to content

fix(web): config merges #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
m8vago merged 72 commits into from
May 11, 2025
Merged

fix(web): config merges #1067

m8vago merged 72 commits into from
May 11, 2025

Conversation

@m8vago
Copy link
Contributor

@m8vago m8vago commented May 9, 2025 •
edited
Loading

  • Fix instance and deployment config merges
  • Fix deployment editing
  • Remove unnecessary image tag fetches
  • Test instance and deployment config merges
  • Add version name templates to envs and storages
  • Fix package environment editing

m8vago and others added 30 commits November 6, 2024 10:16
@m8vago
refactor: container configurations
beabb81
@m8vago
fix: secret handling
839cc1f
@m8vago
fix: build
76bc1de
@m8vago
refactor: remove unused ws messages
2a6dc53
@m8vago
fix: migration
be6c022
@robot9706
feat(web): api & ui
b0c93cb
@m8vago
fix: migration
95e13d6
@m8vago
fix: trying to fix config-bundle related tests
54e16d0
@robot9706
Merge branch 'develop' into feat/deployments-paginated
a6fe6d5
@robot9706
fix: lint
4badf49
@robot9706
Merge branch 'feat/deployments-paginated' into refactor/configurations
63a2cb9
@robot9706
fix: merge
20ff448
@robot9706
feat: deploy list by configbundle
8a28439
@robot9706
feat: config bundle deployment list
66bfe63
@robot9706
feat: use pagination
2a20744
@robot9706
Merge branch 'develop' into refactor/configurations
322ba35
@robot9706
fix: lint
9c6f837
@robot9706
fix: update test
c2b38c9
@robot9706
fix: go lint
4bf2c8f
@robot9706
fix: deploy bug & separate config schema
c5f654f
@m8vago
Revert "fix: deploy bug & separate config schema"
a2482b8 
This reverts commit c5f654f.
@m8vago
fix: deployment null secrets
a780d10
@m8vago
fix: config bundle e2e
a942ad0
@m8vago
fix: golang unit tests
0b37410
@m8vago
fix: setting prefix and container name
885cbd1
@m8vago
Merge branch 'develop' into refactor/configurations
293a2e2
@m8vago
fix: duplicated images
353b164
@m8vago
fix: container name defaults
038495d
@m8vago
fix: storage saving
8b21704
@m8vago
build: disable e2e
f42e87f
robot9706 and others added 19 commits December 12, 2024 14:33
@m8vago m8vago requested a review from a team as a code owner May 9, 2025 16:55
@m8vago m8vago mentioned this pull request May 9, 2025
Closed
@codecov
Copy link

codecov bot commented May 11, 2025

Codecov Report

Attention: Patch coverage is 17.64706% with 126 lines in your changes missing coverage. Please review.

Project coverage is 12.24%. Comparing base (0a7c318) to head (a48df80).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...pp/registry/registry-clients/v2-http-api-client.ts 0.00% 21 Missing ⚠️
web/crux/src/domain/template.ts 21.05% 15 Missing ⚠️
...p/registry/registry-clients/registry-api-client.ts 0.00% 14 Missing ⚠️
...egistry/registry-clients/v2-registry-api-client.ts 0.00% 10 Missing ⚠️
...crux/src/app/container/container-config.service.ts 0.00% 9 Missing ⚠️
...pp/deploy/interceptors/deploy.start.interceptor.ts 0.00% 9 Missing ⚠️
web/crux/src/app/deploy/deploy.service.ts 11.11% 8 Missing ⚠️
...app/registry/registry-clients/github-api-client.ts 0.00% 7 Missing ⚠️
...app/registry/registry-clients/gitlab-api-client.ts 0.00% 7 Missing ⚠️
...app/registry/registry-clients/google-api-client.ts 0.00% 6 Missing ⚠️
... and 7 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1067      +/-   ##
===========================================
+ Coverage    12.05%   12.24%   +0.18%     
===========================================
  Files          301      302       +1     
  Lines        11188    11256      +68     
  Branches      1176     1198      +22     
===========================================
+ Hits          1349     1378      +29     
- Misses        9814     9852      +38     
- Partials        25       26       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@m8vago m8vago force-pushed the fix/config-merges branch from a48df80 to b7d9c42 Compare May 11, 2025 09:41
@m8vago m8vago merged commit 8dbe7e5 into develop May 11, 2025
25 checks passed
@m8vago m8vago deleted the fix/config-merges branch May 11, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@m8vago @robot9706