fix: improve cli and fix external port and root password bug #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1060 +/- ##
========================================
Coverage 12.05% 12.05%
========================================
Files 301 301
Lines 11188 11188
Branches 1176 1176
========================================
Hits 1349 1349
Misses 9814 9814
Partials 25 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nandor-magyar
approved these changes
Apr 15, 2025
Contributor
nandor-magyar
left a comment
There was a problem hiding this comment.
Minor naming comment, LGTM!
nandor-magyar
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, this PR includes a few small improvements to the dyo cli wizard. It adds the missing
ROOT_POSTGRES_PASSWORDfor the database container and fixes the incorrectEXTERNAL_PORTenvironment variable.