Skip to content

Conversation

@robot9706
Copy link
Contributor

Added status filter to list.
Reworked table design.
Removed status badge (list + deploy page)
Rearranged columns.
Fixed "exited" status color.
Fixed status badge size on deploy page.

@robot9706 robot9706 added issue:improvement Issue that makes something better. source:web The scope of the issue or pull request is web. labels Sep 1, 2022
@robot9706 robot9706 requested a review from a team September 1, 2022 13:25
@robot9706 robot9706 self-assigned this Sep 1, 2022
@robot9706 robot9706 changed the title Feat/rework deployment screen feat(web): rework deployment screen Sep 1, 2022
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm know that not related to this task, but can you add a deploy action in the table? Furthermore, if a node is not connected please show the error modal, and don't allow it to deploy.

@robot9706 robot9706 marked this pull request as draft September 2, 2022 09:42
@robot9706 robot9706 force-pushed the feat/rework-deployment-screen branch from 32857f2 to 0cc330e Compare September 2, 2022 12:10
@robot9706 robot9706 marked this pull request as ready for review September 2, 2022 12:13
@robot9706 robot9706 marked this pull request as draft September 5, 2022 07:48
Copy link
Contributor

@balanceee balanceee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robot9706
Copy link
Contributor Author

Moved back to draft, after talking with @polaroi8d. Adding some stuff to the new deployment card.

@robot9706 robot9706 force-pushed the feat/rework-deployment-screen branch from 40af3cc to 6693eb4 Compare September 5, 2022 12:07
@robot9706 robot9706 marked this pull request as ready for review September 5, 2022 12:09
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polaroi8d polaroi8d merged commit 51cde8e into develop Sep 6, 2022
@polaroi8d polaroi8d deleted the feat/rework-deployment-screen branch September 6, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue:improvement Issue that makes something better. source:web The scope of the issue or pull request is web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants