Skip to content

fix: port changes in webb and cli log improvement #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polaroi8d merged 6 commits into from
Oct 28, 2022
Merged

fix: port changes in webb and cli log improvement #303

polaroi8d merged 6 commits into from
Oct 28, 2022

Conversation

@polaroi8d
Copy link
Collaborator

@polaroi8d polaroi8d commented Oct 27, 2022

PR contains:

  • delete unused sh script
  • refactor kratos original port value
  • cli log improvement
  • improve getTemplates promisify

@polaroi8d polaroi8d added issue:improvement Issue that makes something better. source:web The scope of the issue or pull request is web. source:cli The scope of the issue or pull request is CLI tool. pr:fix lang:golang lang:typescript severity:medium labels Oct 27, 2022
@polaroi8d polaroi8d requested a review from a team as a code owner October 27, 2022 12:55
@polaroi8d polaroi8d self-assigned this Oct 27, 2022
ghost
ghost suggested changes Oct 27, 2022
View reviewed changes
ghost
ghost reviewed Oct 27, 2022
View reviewed changes
m8vago
m8vago reviewed Oct 27, 2022
View reviewed changes
nandor-magyar
nandor-magyar reviewed Oct 28, 2022
View reviewed changes
Copy link
Contributor

@nandor-magyar nandor-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍
Small go style suggestions and a cry-for-help regarding the localhost/172.x.x.x issue.

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022

Codecov Report

Base: 13.63% // Head: 13.61% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (31f6b33) compared to base (c2d282b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #303      +/-   ##
===========================================
- Coverage    13.63%   13.61%   -0.02%     
===========================================
  Files           51       51              
  Lines         4876     4883       +7     
===========================================
  Hits           665      665              
- Misses        4189     4196       +7     
  Partials        22       22
Impacted Files Coverage Δ
golang/pkg/cli/cli.go 0.00% <0.00%> (ø)
golang/pkg/cli/config_file.go 0.00% <0.00%> (ø)
golang/pkg/cli/runner.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ghost
ghost approved these changes Oct 28, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polaroi8d polaroi8d merged commit d60f6c1 into develop Oct 28, 2022
@polaroi8d polaroi8d deleted the fix/cli-ports-changes branch October 28, 2022 11:12
clebs pushed a commit to clebs/dyrectorio that referenced this pull request Oct 28, 2022
@clebs
fix: port changes in webb and cli log improvement (dyrector-io#303)
3497582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nandor-magyar nandor-magyar nandor-magyar left review comments

@m8vago m8vago m8vago approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

@polaroi8d polaroi8d

Labels

issue:improvement Issue that makes something better. lang:golang lang:typescript pr:fix severity:medium source:cli The scope of the issue or pull request is CLI tool. source:web The scope of the issue or pull request is web.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@polaroi8d @codecov-commenter @m8vago @nandor-magyar