Skip to content

Conversation

@balanceee
Copy link
Contributor

Updated every enum's first value to be respectful to the latest proto documentation.
Every default value should respect the following syntax: ENUM_TYPE_UNSPECIFIED

@balanceee balanceee requested a review from a team as a code owner October 28, 2022 11:45
@codecov-commenter
Copy link

Codecov Report

Base: 13.61% // Head: 13.61% // No change to project coverage 👍

Coverage data is based on head (4cb8b65) compared to base (d60f6c1).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #306   +/-   ##
========================================
  Coverage    13.61%   13.61%           
========================================
  Files           51       51           
  Lines         4883     4883           
========================================
  Hits           665      665           
  Misses        4196     4196           
  Partials        22       22           
Impacted Files Coverage Δ
golang/internal/dogger/dogger.go 0.00% <0.00%> (ø)
golang/internal/mapper/grpc.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@robot9706 robot9706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👀

@polaroi8d polaroi8d added issue:improvement Issue that makes something better. pr:refactor severity:medium labels Nov 2, 2022
@balanceee balanceee force-pushed the refactor/default-enum-values branch 2 times, most recently from 4a0a60f to e7940b3 Compare November 2, 2022 14:58
@balanceee balanceee force-pushed the refactor/default-enum-values branch from e7940b3 to 50ebb73 Compare November 2, 2022 15:13
@balanceee balanceee merged commit 854a9e0 into develop Nov 2, 2022
@balanceee balanceee deleted the refactor/default-enum-values branch November 2, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue:improvement Issue that makes something better. pr:refactor severity:medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants