Skip to content

chore(agent): change test variable to mock registry #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polaroi8d merged 1 commit into from
Nov 15, 2022
Merged

chore(agent): change test variable to mock registry #338

polaroi8d merged 1 commit into from
Nov 15, 2022

Conversation

@polaroi8d
Copy link
Collaborator

@polaroi8d polaroi8d commented Nov 15, 2022

No description provided.

@polaroi8d polaroi8d added issue:improvement Issue that makes something better. source:agent The scope of the issue or pull request is agent. pr:chore lang:golang severity:high labels Nov 15, 2022
@polaroi8d polaroi8d self-assigned this Nov 15, 2022
@polaroi8d polaroi8d requested a review from a team as a code owner November 15, 2022 07:17
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2022

Codecov Report

Base: 18.33% // Head: 22.23% // Increases project coverage by +3.90% 🎉

Coverage data is based on head (98a1c5c) compared to base (d35f3cd).
Patch coverage: 29.16% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #338      +/-   ##
===========================================
+ Coverage    18.33%   22.23%   +3.90%     
===========================================
  Files           53       54       +1     
  Lines         5073     4969     -104     
===========================================
+ Hits           930     1105     +175     
+ Misses        4120     3791     -329     
- Partials        23       73      +50
Impacted Files Coverage Δ
golang/cmd/crane/crane.go 0.00% <0.00%> (ø)
golang/cmd/dyo/main.go 0.00% <0.00%> (ø)
golang/internal/config/secret.go 56.25% <0.00%> (+1.92%) ⬆️
golang/internal/dogger/dogger.go 0.00% <ø> (ø)
golang/internal/grpc/grpc.go 0.00% <0.00%> (ø)
golang/internal/mapper/grpc.go 75.65% <0.00%> (ø)
golang/internal/util/config.go 0.00% <0.00%> (ø)
golang/pkg/builder/container/exec_builder.go 0.00% <0.00%> (ø)
golang/pkg/cli/cli.go 0.00% <0.00%> (ø)
golang/pkg/cli/config_file.go 0.00% <0.00%> (ø)
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

robot9706
robot9706 requested changes Nov 15, 2022
View reviewed changes
@polaroi8d polaroi8d force-pushed the chore/change-to-mock-registry branch from a53f14a to eccb9f1 Compare November 15, 2022 08:04
@polaroi8d polaroi8d merged commit a154df3 into develop Nov 15, 2022
@polaroi8d polaroi8d deleted the chore/change-to-mock-registry branch November 15, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robot9706 robot9706 robot9706 approved these changes

@nandor-magyar nandor-magyar nandor-magyar approved these changes

+1 more reviewer

@balanceee balanceee balanceee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@polaroi8d polaroi8d

Labels

issue:improvement Issue that makes something better. lang:golang pr:chore severity:high source:agent The scope of the issue or pull request is agent.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@polaroi8d @codecov-commenter @robot9706 @nandor-magyar @balanceee