dagger-for-github release pipeline, replace Makefile with install.sh, add build check to PRs #24

cwlbraa · 2025-06-06T21:09:33Z

This PR removes our Makefile-centric install process and replaces it with a daggerized GHA release process and an install.sh script.

On v* tags, it has GHA use dagger and goreleaser to platform-fanout-build binaries and create a draft GH release. The release operator can then review and publish the release.

The install script finds the most recently published release, downloads the platform-appropriate tarball, checksums, and installs.

The install script also has logic for detecting pre-existing cu system binaries and warning the user to run hash -r to clear command cache.

It also adds a very basic GHA PR check to verify that the project still builds.

Note: this uses a community dagger module for goreleaser. we may find it to be unstable or deleted in the future, but for now it works well enough and the impl looks reasonable to me.

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

Signed-off-by: Connor Braa <connor@dagger.io>

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

Signed-off-by: Connor Braa <connor@dagger.io>

This reverts commit 6c3017d1a48d2fe0f2914a9395059b7510f7ac6c.

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

… port mapping, entrypoint Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

Signed-off-by: Connor Braa <connor@dagger.io>

fix: Makefile

Signed-off-by: Connor Braa <connor@dagger.io>

install.sh

Co-authored-by: Tibor Vass <tiborvass@users.noreply.github.com> Signed-off-by: Connor Braa <3478454+cwlbraa@users.noreply.github.com>

install.sh

Signed-off-by: Connor Braa <connor@dagger.io>

README.md

install.sh

…atform Signed-off-by: Connor Braa <connor@dagger.io>

grouville · 2025-06-09T19:09:08Z

install.sh

+    local arch=$(detect_arch)
+    log_info "Detected platform: $os/$arch"
+
+    local version=$(get_latest_version)


It would be nice for this to be an env var, like in Dagger, to be able to specify any version

can be added later. right now it's a pain to test that manually as there's 0 tagged releases.

Signed-off-by: Connor Braa <connor@dagger.io>

grouville · 2025-06-09T22:21:48Z

@cwlbraa

Testing Summary & Implementation Review

I’ve reviewed and tested the new GoReleaser + Dagger setup locally. Here's a brief summary and exact commands for reproducibility:

✅ Successfully tested:

Dagger Setup and Functions:

curl -L https://dl.dagger.io/dagger/install.sh | DAGGER_VERSION=0.18.9 sh
./bin/dagger call build export --path ./cu-local
./bin/dagger call build-multi-platform export --path ./dist
./bin/dagger call release --help

Built arm64 Linux binary.
Created multi-platform binaries (Linux/Darwin, amd64/arm64).
Validated release command parameters.

GoReleaser Config (with Docker):

docker run --rm -v "$(pwd)":/workspace -w /workspace goreleaser/goreleaser:latest check
docker run --rm -v "$(pwd)":/workspace -w /workspace -e GITHUB_TOKEN=fake-token goreleaser/goreleaser:latest release --snapshot --clean | head -30

Config validated, snapshot build successful.
Community module works fine.

Install Script:
```
chmod +x install.sh
bash install.sh --help
bash install.sh 2>&1 | head -20
```
- Properly detected Docker and platform.
- Expected failure for fetching non-existent releases.

Build Outputs:

ls -la cu-local dist/
find dist/ -name "cu"

⚠️ Could not test (requires actual GitHub setup):

GitHub Actions execution
Real releases
Install script fetching real releases

🔍 Implementation Notes:

Critical findings:
🚨 Bug: Install script uses bash features (pipefail, local) but specifies POSIX shell (#!/bin/sh). Needs correction:
```
# Change to:
#!/usr/bin/env bash
```

To test the shell issue:

  ./install.sh --help  # Fails with dash: "Illegal option -o pipefail"
  bash install.sh --help  # Works fine

aluzzardi and others added 30 commits May 22, 2025 16:25

initial commit

d24955b

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

state management

f5d183a

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

.cursor rule

a03ac8f

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

add more tools

c2b67aa

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

cleanup tools

21dd66f

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

container.diff

aa43006

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

cleanup

4ebe5a2

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

goosehint

cb67195

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

container_file_read: fix indexes

0a7859c

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

mcp: use request helpers

0639659

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

mcp: improve error responses

c620533

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

add (broken) examples

4c30818

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

add README.md

32f5695

Signed-off-by: Connor Braa <connor@dagger.io>

filesystem: split fs ops into its own file

d94a458

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

fork tool, use unclear rn

50255e7

Signed-off-by: Connor Braa <connor@dagger.io>

add multibuild example

9db255f

Signed-off-by: Connor Braa <connor@dagger.io>

Revert "fork tool, use unclear rn"

bcb5b4d

This reverts commit 6c3017d1a48d2fe0f2914a9395059b7510f7ac6c.

add support for revisions, history, revert

c967f55

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

container: fork support

4fc58f8

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

fs: revision diff

ab9f638

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

container: background run support

fbc0f7d

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

examples: hello world

f93253a

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

examples: add history, remove git

3b15df1

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

examples update

de7602f

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

README: update

217124b

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

container: tweak run tools to be more useful: env variables, internal…

d25c0df

… port mapping, entrypoint Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

examples: simplify parallel

a6a1228

Signed-off-by: Andrea Luzzardi <andrea@luzzardi.com>

legit slog wiring

a518ceb

Signed-off-by: Connor Braa <connor@dagger.io>

wip

1c51503

Signed-off-by: Connor Braa <connor@dagger.io>

move containers to a subdirectory

62e379c

Signed-off-by: Connor Braa <connor@dagger.io>

cwlbraa and others added 3 commits June 9, 2025 11:20

document release process

62b6cbe

Signed-off-by: Connor Braa <connor@dagger.io>

go mod tidy (prolly breaks the release tho)

48366b6

Signed-off-by: Connor Braa <connor@dagger.io>

Merge pull request #43 from grouville/fix-makefile

25cec17

fix: Makefile

cwlbraa changed the title ~~wip: dagger-for-github release pipeline~~ dagger-for-github release pipeline Jun 9, 2025

RELEASING.md improvements

2284678

Signed-off-by: Connor Braa <connor@dagger.io>

cwlbraa marked this pull request as ready for review June 9, 2025 18:32

cwlbraa requested review from aluzzardi, gkogan, shykes and tiborvass June 9, 2025 18:32

cwlbraa changed the title ~~dagger-for-github release pipeline~~ dagger-for-github release pipeline (replace Makefile with install.sh & add build check to PRs) Jun 9, 2025

cwlbraa changed the title ~~dagger-for-github release pipeline (replace Makefile with install.sh & add build check to PRs)~~ dagger-for-github release pipeline, replace Makefile with install.sh, add build check to PRs Jun 9, 2025

tiborvass reviewed Jun 9, 2025

View reviewed changes

install.sh Outdated Show resolved Hide resolved

add pipefail to install script

bbb4ece

Co-authored-by: Tibor Vass <tiborvass@users.noreply.github.com> Signed-off-by: Connor Braa <3478454+cwlbraa@users.noreply.github.com>

tiborvass reviewed Jun 9, 2025

View reviewed changes

install.sh Outdated Show resolved Hide resolved

move -h handling inside of main in case of partial downloads

7987272

Signed-off-by: Connor Braa <connor@dagger.io>

tiborvass reviewed Jun 9, 2025

View reviewed changes

README.md Show resolved Hide resolved

tiborvass reviewed Jun 9, 2025

View reviewed changes

install.sh Outdated Show resolved Hide resolved

fix build instruction in readme and update dagger build fn to take pl…

8566917

…atform Signed-off-by: Connor Braa <connor@dagger.io>

grouville reviewed Jun 9, 2025

View reviewed changes

cwlbraa added 3 commits June 9, 2025 12:27

remove hack/ and add replacements

6636d5b

Signed-off-by: Connor Braa <connor@dagger.io>

check for git when installing

e808b27

Signed-off-by: Connor Braa <connor@dagger.io>

clarify install instructions

4e319a7

Signed-off-by: Connor Braa <connor@dagger.io>

cwlbraa requested review from grouville and tiborvass June 9, 2025 19:34

Merge branch 'main' into release-tags

3c7bd8e

tiborvass closed this Jun 9, 2025

tiborvass force-pushed the main branch from 25cec17 to b730139 Compare June 9, 2025 22:04

cwlbraa mentioned this pull request Jun 9, 2025

dagger-for-github release pipeline, replace Makefile with install.sh, add build check to PRs #47

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

dagger-for-github release pipeline, replace Makefile with install.sh, add build check to PRs #24

dagger-for-github release pipeline, replace Makefile with install.sh, add build check to PRs #24

Uh oh!

cwlbraa commented Jun 6, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

grouville Jun 9, 2025

Uh oh!

cwlbraa Jun 9, 2025

Uh oh!

grouville commented Jun 9, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

dagger-for-github release pipeline, replace Makefile with install.sh, add build check to PRs #24

dagger-for-github release pipeline, replace Makefile with install.sh, add build check to PRs #24

Uh oh!

Conversation

cwlbraa commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

grouville Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

cwlbraa Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

grouville commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing Summary & Implementation Review

✅ Successfully tested:

⚠️ Could not test (requires actual GitHub setup):

🔍 Implementation Notes:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

cwlbraa commented Jun 6, 2025 •

edited

Loading

grouville commented Jun 9, 2025 •

edited

Loading