Skip to content

[#942] Add permissions field to the config #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yottahmd merged 15 commits into from
May 29, 2025
Merged

[#942] Add permissions field to the config #962

yottahmd merged 15 commits into from
May 29, 2025

Conversation

@yottahmd
Copy link
Collaborator

@yottahmd yottahmd commented May 29, 2025 •
edited
Loading

Resolves #942

This PR adds a simple functionality to allow user to config permission of the UI and API.
Example config:

permissions:
  writeDags: false
  runDags: false

This will effectively result readonly UI and API.

It also includes some fixes on minor issues of the UI.

@yottahmd yottahmd linked an issue May 29, 2025 that may be closed by this pull request
Readonly UI #942
Closed
@yottahmd yottahmd mentioned this pull request May 29, 2025
Merged
26 tasks
@yottahmd yottahmd merged commit 33a5245 into next May 29, 2025
4 checks passed
@yottahmd yottahmd deleted the fix-queue-issue branch May 29, 2025 12:44
@codecov
Copy link

codecov bot commented May 29, 2025

Codecov Report

Attention: Patch coverage is 51.85185% with 13 lines in your changes missing coverage. Please review.

Project coverage is 61.39%. Comparing base (35b0432) to head (65791e6).
Report is 1 commits behind head on next.

Files with missing lines Patch % Lines
internal/persistence/localqueue/reader.go 22.22% 7 Missing ⚠️
internal/scheduler/scheduler.go 0.00% 5 Missing ⚠️
internal/models/queue.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #962      +/-   ##
==========================================
- Coverage   61.45%   61.39%   -0.06%     
==========================================
  Files          83       83              
  Lines       10404    10419      +15     
==========================================
+ Hits         6394     6397       +3     
- Misses       3368     3378      +10     
- Partials      642      644       +2
Files with missing lines Coverage Δ
internal/config/config.go 76.74% <ø> (ø)
internal/config/loader.go 90.32% <100.00%> (+0.26%) ⬆️
internal/models/queue.go 0.00% <0.00%> (ø)
internal/scheduler/scheduler.go 52.40% <0.00%> (ø)
internal/persistence/localqueue/reader.go 60.93% <22.22%> (-1.48%) ⬇️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b0432...65791e6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Readonly UI

2 participants

@yottahmd