schemas/dag.schema.json (1)

656-716: continueOn union matches runtime, but schema is stricter on string casing

The oneOf union and nested exitCode/output shapes line up with the new builder behavior, but the enum branch only allows lowercase "skipped"/"failed" while buildContinueOn accepts case‑insensitive values (e.g. "SKIPPED" is tested). If case‑insensitive input is intended, consider either:

• Expanding the enum (or using a pattern) to reflect that, or
• Tightening the builder to require the canonical lowercase values.

This avoids schema vs runtime discrepancies for validators.

internal/core/spec/builder_test.go (1)

1281-1353: Solid coverage for new continueOn forms

These tests nicely exercise the shorthand string values (including case‑insensitive handling), invalid strings, and the object form with exitCode and markSuccess, and they fit well into the existing subtest structure. If you want to tighten coverage further, you could add cases for:

• exitCode as a single string (e.g. "1") and mixed invalid types, and
• output as both string and array.

Not strictly necessary for this change set.

internal/core/spec/builder.go (1)

1308-1346: Add TrimSpace to continueOn string parsing and consider map[any]any handling for YAML robustness

The buildContinueOn implementation is correct; two small improvements align it with patterns used elsewhere in the builder:

1. Normalize whitespace in shorthand strings

Throughout builder.go, string values are normalized with strings.TrimSpace() before processing (e.g., Group, Description, Type, Queue, Name, ID, Script, etc.). The shorthand continueOn parser should do the same so that " skipped " or "failed " work as expected:

	case string:
		// Shorthand syntax: "skipped" or "failed"
-		switch strings.ToLower(v) {
+		switch strings.ToLower(strings.TrimSpace(v)) {
		case "skipped":
			step.ContinueOn.Skipped = true
		case "failed":
			step.ContinueOn.Failure = true

2. Handle map[any]any for YAML robustness

The buildRegistryAuths function handles both map[string]any and map[any]any to accommodate YAML's type preservation. Although gopkg.in/yaml.v3 defaults to map[string]interface{} for string-keyed mappings, edge cases and version variations can produce map[any]any. Adding a fallback case here (converting keys to strings before processing) would make continueOn more defensive and consistent with other handlers in the builder.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: CR
Repo: dagu-org/dagu PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-04T10:34:17.051Z
Learning: Applies to **/*_test.go : Co-locate Go tests as `*_test.go`; favour table-driven cases and cover failure paths

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro