Skip to content

fix(auth): allow API token to perform write/execute operations #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yottahmd merged 2 commits into from
Dec 15, 2025
Merged

fix(auth): allow API token to perform write/execute operations #1486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ba69de
fix(auth): allow API token to perform write/execute operations
yottahmd Dec 15, 2025
9c2c138
add failure test
yottahmd Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions internal/service/frontend/api/v2/auth_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,49 @@ func TestAuth_BuiltinModeWithAPIToken(t *testing.T) {
ExpectStatus(http.StatusOK).Send(t)
}

// TestAuth_BuiltinModeWithAPIToken_WriteExecute tests that API token can perform
// write and execute operations in builtin mode (regression test for issue #1478)
func TestAuth_BuiltinModeWithAPIToken_WriteExecute(t *testing.T) {
t.Parallel()
server := test.SetupServer(t, test.WithConfigMutator(func(cfg *config.Config) {
cfg.Server.Auth.Mode = config.AuthModeBuiltin
cfg.Server.Auth.Builtin.Admin.Username = "admin"
cfg.Server.Auth.Builtin.Admin.Password = "adminpass"
cfg.Server.Auth.Builtin.Token.Secret = "jwt-secret-key"
cfg.Server.Auth.Builtin.Token.TTL = 24 * time.Hour
// Also configure API token
cfg.Server.Auth.Token.Value = "my-api-token"
}))

spec := `
steps:
- name: test
command: echo hello
`

// Without auth - write should fail
server.Client().Post("/api/v2/dags", api.CreateNewDAGJSONRequestBody{
Name: "api_token_test_dag",
Spec: &spec,
}).ExpectStatus(http.StatusUnauthorized).Send(t)

// Test write operation (create DAG) with API token - this was failing before the fix
server.Client().Post("/api/v2/dags", api.CreateNewDAGJSONRequestBody{
Name: "api_token_test_dag",
Spec: &spec,
}).WithBearerToken("my-api-token").ExpectStatus(http.StatusCreated).Send(t)

// Test execute operation (start DAG) with API token - this was also failing
server.Client().Post("/api/v2/dags/api_token_test_dag/start", api.ExecuteDAGJSONRequestBody{}).
WithBearerToken("my-api-token").
ExpectStatus(http.StatusOK).Send(t)

// Test delete operation with API token
server.Client().Delete("/api/v2/dags/api_token_test_dag").
WithBearerToken("my-api-token").
ExpectStatus(http.StatusNoContent).Send(t)
}

// TestAuth_BuiltinModeIgnoresBasicAuth tests that basic auth is ignored in builtin mode
func TestAuth_BuiltinModeIgnoresBasicAuth(t *testing.T) {
t.Parallel()
Expand Down
11 changes: 10 additions & 1 deletion internal/service/frontend/auth/middleware.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,16 @@ func Middleware(opts Options) func(next http.Handler) http.Handler {

// Try API token authentication if enabled
if opts.APITokenEnabled && checkAPIToken(r, opts.APIToken) {
next.ServeHTTP(w, r)
// API token grants full admin access
// Inject a synthetic admin user so that permission checks (requireWrite,
// requireExecute, requireAdmin) work correctly in builtin auth mode
adminUser := &auth.User{
ID: "api-token",
Username: "api-token",
Role: auth.RoleAdmin,
}
ctx := auth.WithUser(r.Context(), adminUser)
next.ServeHTTP(w, r.WithContext(ctx))
return
}

Expand Down
Loading