Enable filtering on a range of assertions#6077
Merged
keyboardDrummer merged 5 commits intoJan 24, 2025
Merged
Conversation
MikaelMayer
previously approved these changes
Jan 24, 2025
MikaelMayer
left a comment
Member
There was a problem hiding this comment.
Disabling auto-merge so that you can choose to apply suggestions, otherwise looks good 👍
| class LineRange(int start, int end) { | ||
| public int Start { get; } = start; | ||
| public int End { get; } = end; | ||
|
|
Member
There was a problem hiding this comment.
A few GitHub warnings above
| public int End { get; } = end; | ||
|
|
||
| public bool Contains(int value) { | ||
| return start <= value && value <= end; |
Member
There was a problem hiding this comment.
I'm ok to consider end to be inclusive here.
Co-authored-by: Mikaël Mayer <MikaelMayer@users.noreply.github.com>
MikaelMayer
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed?
Besides
--filter-position :<line>, also support--filter-position :<start>-<end>,--filter-position :<start>-and--filter-position :-<end>How has this been tested?
Extended existing test
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.