Skip to content

fix: scrape all goos/goarch pair for stdlib #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daixiang0 merged 6 commits into from
Mar 31, 2025
Merged

fix: scrape all goos/goarch pair for stdlib #208

daixiang0 merged 6 commits into from
Mar 31, 2025

Conversation

@Zxilly
Copy link
Contributor

@Zxilly Zxilly commented May 30, 2024 •
edited
Loading

Closes: #209

Now syscall/js can be recognized correctly.

@Zxilly Zxilly force-pushed the master branch 3 times, most recently from ea1161f to a6785a8 Compare May 30, 2024 07:55
@Zxilly Zxilly mentioned this pull request Jul 8, 2024
Closed
@Zxilly
Copy link
Contributor Author

Zxilly commented Sep 29, 2024

@daixiang0 hello, any updates?

alexandear
alexandear reviewed Nov 8, 2024
View reviewed changes
@Zxilly
Copy link
Contributor Author

Zxilly commented Nov 8, 2024

The patches you suggested are great, I'll apply those when I touch my computer. But it seems that the author hasn't responded for a long time and I don't know if he still concerns himself with this project.

@daixiang0
Copy link
Owner

daixiang0 commented Nov 11, 2024

@Zxilly thanks for care, could you update then we can make it land.

@Zxilly
Copy link
Contributor Author

Zxilly commented Nov 11, 2024

Done

alexandear
alexandear reviewed Nov 11, 2024
View reviewed changes
@Zxilly Zxilly force-pushed the master branch 2 times, most recently from be58ff5 to 4889c14 Compare November 11, 2024 14:44
daixiang0
daixiang0 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Owner

@daixiang0 daixiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daixiang0
Copy link
Owner

daixiang0 commented Nov 15, 2024

@Zxilly Please fix lint issue.

alexandear
alexandear approved these changes Nov 15, 2024
View reviewed changes
Zxilly and others added 6 commits November 15, 2024 18:22
@Zxilly
fix: scrape all goos/goarch pair for stdlib
27c2c2c 
Signed-off-by: Zxilly <zxilly@outlook.com>
@Zxilly @alexandear
perf: init pkgs with size
860f926 
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
Signed-off-by: Zxilly <zxilly@outlook.com>
@Zxilly
feat: use errgroup instead
945b75f 
Signed-off-by: Zxilly <zxilly@outlook.com>
@Zxilly @alexandear
chore: simplify string compare
3fab880 
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
Signed-off-by: Zxilly <zxilly@outlook.com>
@Zxilly
fix: update import
3ee4423 
Signed-off-by: Zxilly <zxilly@outlook.com>
@Zxilly @alexandear
chore: use strings.Cut
051e697 
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
Signed-off-by: Zxilly <zxilly@outlook.com>

Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
Signed-off-by: Zxilly <zxilly@outlook.com>
@Zxilly Zxilly requested a review from daixiang0 December 14, 2024 14:15
@joshuasing
Copy link

joshuasing commented Mar 28, 2025 •
edited
Loading

@daixiang0 (cc @Zxilly) Hi, I just ran into syscall/js not being included in the std packages list.
It looks to be outdated now, however it would be nice to have this merged.

Is there anything currently blocking this pull request? Can I do anything to help speed up having this merged?

Thanks!

@joshuasing joshuasing mentioned this pull request Mar 28, 2025
Merged
@Zxilly
Copy link
Contributor Author

Zxilly commented Mar 28, 2025

I don't think the maintainer cares much about the project anymore, you could create a group for syscall/js to act as a workaround.

@daixiang0
Copy link
Owner

daixiang0 commented Mar 31, 2025

@Zxilly thanks for contribution!

@daixiang0 daixiang0 merged commit 7515d24 into daixiang0:master Mar 31, 2025
1 check passed
@joshuasing
Copy link

joshuasing commented Mar 31, 2025

Thank you!

@BrewTestBot BrewTestBot mentioned this pull request Jul 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daixiang0 daixiang0 Awaiting requested review from daixiang0

1 more reviewer

@alexandear alexandear alexandear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New std lib unique,iter in go1.23 can not be recognized

4 participants

@Zxilly @daixiang0 @joshuasing @alexandear