Skip to content

Conversation

@benverhees
Copy link
Contributor

@benverhees benverhees commented Nov 17, 2025

Summary

This PR applies ESLint code style fixes across the codebase to ensure consistent formatting and compliance with the project's linting rules. The majority of changes were automatically fixed by running npm run lint:fix, with three additional manual fixes applied to the touched files.

Auto-fixed changes (via npm run lint:fix):

  • String literal standardization: Converting double quotes to single quotes throughout JavaScript/TypeScript files
  • Code formatting improvements: Fixing indentation, removing unnecessary parentheses, and correcting whitespace issues
  • ESLint compliance: Adding appropriate eslint-disable comments where intentional rule violations are necessary (e.g., import cycles, disabled tests, commented-out tests)

Manual fixes:

  • Three specific issues in the touched files that required manual intervention beyond what the auto-fixer could handle

These changes improve code consistency and maintainability without affecting functionality. All changes are purely stylistic and do not modify any business logic or behavior.

Note: This PR only addresses the auto-fixable lint issues and three manual fixes in the specific files that were touched. There are still remaining lint errors and warnings in other parts of the codebase (186 problems: 85 errors, 101 warnings) that are outside the scope of this PR and will need to be addressed separately.

I added two entries to the eslint ignore list to prevent scanning of build artifacts and Python virtual environments:

      '**/dist/**/*',
      '.venv/**/*',

Change Type

Please delete any irrelevant options.

  • Bug fix (non-breaking change which fixes an issue)

Testing

All existing tests should continue to pass as these are purely stylistic changes. The changes were generated by running npm run lint:fix followed by three manual fixes.

Test Configuration:

No special test configuration required. Standard test suite execution should verify that:

  • All unit tests pass
  • No functionality has been affected
  • ESLint rules are satisfied for the files modified in this PR

Testing Steps:

  1. Run the full test suite: npm test
  2. Verify ESLint on changed files: The files modified in this PR should pass linting
  3. Confirm no new warnings or errors are introduced in the touched files

Note: Running npm run lint will still show errors/warnings in other files that are not part of this PR. This PR only fixes the auto-fixable issues and three manual fixes in the specific files that were modified.

Checklist

Please delete any irrelevant options.

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

@benverhees benverhees marked this pull request as ready for review November 17, 2025 20:39
@benverhees benverhees changed the title chore: Apply ESLint auto-fixes and manual corrections 🧹 chore: Apply ESLint auto-fixes and manual corrections Nov 18, 2025
@danny-avila danny-avila changed the base branch from main to dev-staging November 25, 2025 20:21
@danny-avila
Copy link
Owner

changed base branch to dev-staging, removed legacy code so some of these lints are no longer necessary. Feel free start a new PR with lints applied using dev-staging as base branch if that's easier

@danny-avila danny-avila force-pushed the dev-staging branch 4 times, most recently from aaebe0d to 78c9c37 Compare November 28, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants