Use GitHub files API with pagination for PR diff#1491
Merged
Conversation
manicmaniac
approved these changes
Jun 26, 2024
manicmaniac
left a comment
Member
There was a problem hiding this comment.
Good suggestion, thank you 👍
Member
|
@timbaev Could you please add CHANGELOG entry before merging? |
Contributor
Author
No problem, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used the same idea as in danger-js to get a list of files for PR diff using List pull requests files API from GitHub with pagination. The old Get a pull request API has a limit of 300 files and there is no pagination, which is why Danger can't leave an Inline comment with error 406 from the GitHub API.
Fixes #1489