fix(connection): avoid nil pointer panic on socket file stat error#309
Merged
Merged
Conversation
danvergara
approved these changes
May 24, 2026
Owner
|
@SAY-5 Thanks for this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
socketFileExistsonly returns early whenos.Statfails with an "not exists" error. For any other stat error (for exampleENOTDIRwhen a path component is a regular file, or a permission error),infoisnilbut the code still callsinfo.IsDir(), causing a nil pointer dereference panic.This is reachable from
BuildConnectionFromOptsfor the MySQL driver when a user passes a--socketpath whose parent is not a directory. The fix treats any stat error as "socket does not exist".Type of change
How Has This Been Tested?
Added
TestSocketFileExistsStatError, which points the helper at a.sockpath that traverses through a regular file (yielding a non-IsNotExist stat error). The test panics on the old code and passes with the fix. Verified withgo test -short -race ./pkg/connection/,go vet, andgofmt.Checklist: