Skip to content

run-tx bundles source by default#808

Merged
d-xo merged 19 commits into
masterfrom
run-tx-bundle
Sep 23, 2021
Merged

run-tx bundles source by default#808
d-xo merged 19 commits into
masterfrom
run-tx-bundle

Conversation

@d-xo
Copy link
Copy Markdown
Contributor

@d-xo d-xo commented Sep 21, 2021

Description

seth run-tx now attempts to pull contract source from etherscan if ETHERSCAN_API_KEY is set.

Fixes #789

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

@d-xo d-xo changed the title Run tx bundle run-tx bundles source by default Sep 21, 2021
@transmissions11
Copy link
Copy Markdown
Contributor

tried this out locally and using the command leaves behind the bundled contracts pulled from etherscan... any chance we could modify this to pull source into a temp directory and purge it after run-tx?

otherwise there's gonna be junk contracts left all over ppls desktops hehe

@d-xo
Copy link
Copy Markdown
Contributor Author

d-xo commented Sep 22, 2021

tried this out locally and using the command leaves behind the bundled contracts pulled from etherscan... any chance we could modify this to pull source into a temp directory and purge it after run-tx?

done

@d-xo d-xo merged commit e41b6cd into master Sep 23, 2021
@d-xo d-xo deleted the run-tx-bundle branch September 23, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

seth debug --fast/--unsound

2 participants