Skip to content

seth: debug: fix#812

Merged
d-xo merged 2 commits into
masterfrom
fix-seth-debug
Oct 7, 2021
Merged

seth: debug: fix#812
d-xo merged 2 commits into
masterfrom
fix-seth-debug

Conversation

@d-xo
Copy link
Copy Markdown
Contributor

@d-xo d-xo commented Sep 22, 2021

Description

Fixes seth debug (which was passing the whole tx object instead of just the tx hash into seth run-tx). @MrChico has there been an api change since this was written? I don't understand how it ever worked, but it definitely did in the past, so I'm a little confused....

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

@d-xo d-xo requested a review from MrChico September 22, 2021 13:34
@MrChico
Copy link
Copy Markdown
Member

MrChico commented Sep 23, 2021

hmm yes quite odd. What you have here makes more sense and I share your confusion

@hrkrshnn
Copy link
Copy Markdown

This branch seems to fix an issue that I came across while running:

seth debug 0xf4bfef1655f2092cf062c008153a5be66069b2b1fedcacbf4037c1f3cc8a9f45

seth-debug: info: transaction (2/47)seth-run-tx: malformed transaction hash or data: accessList 

Context

@d-xo d-xo merged commit 9d3ca57 into master Oct 7, 2021
@d-xo d-xo deleted the fix-seth-debug branch October 7, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants