style: update PR template wording #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loses', not 'close' Signed-off-by: Casper Nielsen <casper@diagrid.io>
sicoyle
requested changes
Dec 12, 2025
Collaborator
sicoyle
left a comment
There was a problem hiding this comment.
I don't think this is grammatically correct tbh...
If you keep "will" there, then it should be "will close", not "will closes"
Appreciate you taking a look at the PR template!
Signed-off-by: Casper Nielsen <casper@diagrid.io>
Contributor
Author
You are absolutely right @sicoyle - I didn't even consider the grammar of the sentence. Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…loses', not 'close'
Description
Ensure the github auto-link feature catches the issue link by using "closes" instead of "close"
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.