Skip to content

Updating dockerfiles used in Tutorial make build (C#,Python,Node,ReactClient) #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yaron2 merged 3 commits into from
Jul 24, 2024
Merged

Updating dockerfiles used in Tutorial make build (C#,Python,Node,ReactClient) #1062

yaron2 merged 3 commits into from
Jul 24, 2024

Conversation

@paulyuk
Copy link
Contributor

@paulyuk paulyuk commented Jul 24, 2024

Description

Updating tools chains in dockerfiles to:

  • use latest of each language stack's SDK that is compatible with app
  • multi stage build in .net for performance and size
  • build and test clean with make build in each tutorial folder
  • leveraged by build.yaml github action workflow

Issue reference

This is a companion fix to #1058 for the other languages

paulyuk added 2 commits July 24, 2024 00:56
@paulyuk
Updating gitignore to exclude out/ from dotnet publish
360d26c 
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk
Fixing build.yaml github action workflow with modern dockerfiles. go …
c41b664 
…for dist calculator already fixed by dapr#1058

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk paulyuk added dependencies Pull requests that update a dependency file P1 area/tutorials labels Jul 24, 2024
@paulyuk paulyuk added this to the 1.14 milestone Jul 24, 2024
@paulyuk paulyuk self-assigned this Jul 24, 2024
@paulyuk paulyuk mentioned this pull request Jul 24, 2024
Merged
4 tasks
@paulyuk paulyuk added the build label Jul 24, 2024
@paulyuk
Updating csharp dockerfile with correct entry point, and do not expli…
2433fc4 
…citly expose port

Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk paulyuk requested a review from msfussell July 24, 2024 08:47
@paulyuk
Copy link
Contributor Author

paulyuk commented Jul 24, 2024

I tested every dockerfile's build at runtime to ensure compat.

msfussell
msfussell approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaron2 yaron2 merged commit 4f59e09 into dapr:master Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msfussell msfussell msfussell approved these changes

@artursouza artursouza Awaiting requested review from artursouza

@antontroshin antontroshin Awaiting requested review from antontroshin

Assignees

@paulyuk paulyuk

Labels

area/tutorials build dependencies Pull requests that update a dependency file P1

Projects

v1.14 Release Tracking Board
Status: Done

Milestone

1.14

Development

Successfully merging this pull request may close these issues.

3 participants

@paulyuk @msfussell @yaron2