-
Notifications
You must be signed in to change notification settings - Fork 549
Updated Badges for Build Status, License, and Added Social Media Badges in README.md #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Updated Build Status badge (currently a broken image) * Updated Apache License to reflect the Repo License accurately as Apache 2.0 (currently "Apache") * Added social media badges for discord, youtube and X Signed-off-by: Erin La <107987318+giterinhub@users.noreply.github.com>
|
The checks fail due to an HTTP Error for the X Link. The link is correct, and works in a browser. When using the old Twitter domain, it also redirects instantly to the X link. I don't think the issue lies in the URL in this PR, but insteas with the Links-checker. I also ran this test with https://twitter.com/daprdev with and without a trailing "/" - all tests returned 400 for x or twitter URLs. Maybe update Mechanical Markdown? Or must the x.com link be removed completely? :(
|
alicejgibbons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try ignore links
Signed-off-by: Alice Gibbons <alicejgibbons@gmail.com>
Signed-off-by: Alice Gibbons <alicejgibbons@gmail.com>
alicejgibbons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@holopin-bot @giterinhub Thank you! Here's a digital badge as a small token of appreciation. |
|
Congratulations @giterinhub, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmbs2r1os205207i9u9illpfh This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Description
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: