Skip to content

Conversation

@giterinhub
Copy link
Contributor

Description

  • Updated Build Status badge (currently a broken image)
  • Updated Apache License to reflect the Repo License accurately as Apache 2.0 (currently "Apache")
  • Added social media badges for discord, youtube and X

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

* Updated Build Status badge (currently a broken image)
* Updated Apache License to reflect the Repo License accurately as Apache 2.0 (currently "Apache")
* Added social media badges for discord, youtube and X

Signed-off-by: Erin La <107987318+giterinhub@users.noreply.github.com>
@giterinhub giterinhub requested review from a team as code owners April 5, 2025 21:02
@giterinhub
Copy link
Contributor Author

The checks fail due to an HTTP Error for the X Link.

The link is correct, and works in a browser. When using the old Twitter domain, it also redirects instantly to the X link. I don't think the issue lies in the URL in this PR, but insteas with the Links-checker. I also ran this test with https://twitter.com/daprdev with and without a trailing "/" - all tests returned 400 for x or twitter URLs. Maybe update Mechanical Markdown? Or must the x.com link be removed completely? :(

External link validation: ... https://x.com/daprdev Status: 400

alicejgibbons
alicejgibbons previously approved these changes May 16, 2025
Copy link
Contributor

@alicejgibbons alicejgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try ignore links

Signed-off-by: Alice Gibbons <alicejgibbons@gmail.com>
Signed-off-by: Alice Gibbons <alicejgibbons@gmail.com>
Copy link
Contributor

@alicejgibbons alicejgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alicejgibbons alicejgibbons merged commit 91ef095 into dapr:master May 19, 2025
7 checks passed
@marcduiker
Copy link
Contributor

@holopin-bot @giterinhub Thank you! Here's a digital badge as a small token of appreciation.

@holopin-bot
Copy link

holopin-bot bot commented Jun 11, 2025

Congratulations @giterinhub, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmbs2r1os205207i9u9illpfh

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants