Skip to content

Doctrine/DBAL 4 conflict #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zanbaldwin merged 1 commit into from
Jun 7, 2024
Merged

Doctrine/DBAL 4 conflict #92

zanbaldwin merged 1 commit into from
Jun 7, 2024

Conversation

@DarthLegiON
Copy link
Contributor

@DarthLegiON DarthLegiON commented May 10, 2024 •
edited
Loading

Doctrine DBAL v4 requires PHP 8 and contains some changes that break compatibility with IP column type definition. DBAL 2-3 and ORM v3 works fine. To fix any problems on automated update we must mark DBAL v4 as conflict.

More discussion here: #88

@DarthLegiON
Copy link
Contributor Author

DarthLegiON commented Jun 6, 2024

@zanbaldwin could you please pay some attention to this PR?

zanbaldwin
zanbaldwin approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@zanbaldwin zanbaldwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this achieves. If I release this as a version then if Composer does encounter a conflict then it will just use the previous version that doesn't and we still have the same problem (although it's been a long week and I may be wrong on how Composer resolves dependencies).

However, I don't see any downside to this approach either, so I'll tag this as a new version today.

@zanbaldwin zanbaldwin merged commit d5f0699 into darsyn:master Jun 7, 2024
@zanbaldwin
Copy link
Member

zanbaldwin commented Jun 7, 2024

I've just realised that adding the conflict will prevent users who want to use this library without the Doctrine types in the same project that uses Doctrine DBAL 4+. That's a breaking change and requires a major version bump.

If I'm going to do a major version bump I might as well split this project into darsyn/ip and darsyn/ip-doctrine. That way the PHP version requirements for Doctrine can change (and support Doctrine 4+) while the library can still support PHP 5.6.

I'm going to do this today, because otherwise it'll get delayed again.

@zanbaldwin
Copy link
Member

zanbaldwin commented Jun 7, 2024

New releases:

I couldn't merge your pull request into a different repository, so I listed you as a co-author on the initial commit.

Take a look, and if you or I haven't found any obvious bugs over the weekend I'll release them both as stable on Monday. I even have a calendar reminder set!

Now the darsyn/ip-doctrine can update its PHP version requirement and support Doctrine DBAL 4+ without affecting the main library 🙂

@DarthLegiON
Copy link
Contributor Author

DarthLegiON commented Jun 8, 2024

Thanks, i'll test it today later!

@DarthLegiON DarthLegiON deleted the patch-1 branch June 29, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanbaldwin zanbaldwin zanbaldwin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DarthLegiON @zanbaldwin