Ignore all file types being converted as potential outputs #44
Conversation
mfix22
left a comment
There was a problem hiding this comment.
Thanks so much @ericadamski ! We will probably merge this without the small comment, but just wanted to make it in case you got to it before us 😄
| !files.map(file => file.path).includes(file.path))) | ||
|
|
||
| const getUniqueExtensions = files => { | ||
| const normalizeExtension = name => { |
There was a problem hiding this comment.
You could probably declare normalizeExtension outside of this function (:
There was a problem hiding this comment.
Sorry I didn't make it :(
There was a problem hiding this comment.
Don't worry about it 😄I was just nitpicking. Update not necessary. Thanks a lot for this bug fix! We are going to release today.
There was a problem hiding this comment.
If have more time next bug/feature I can clean up this file and test them all! 🙌
There was a problem hiding this comment.
Go for it! 👍 that would be massively appreciated. Also thanks so much for writing that test! We really should have been better about doing so
There was a problem hiding this comment.
No shame! TDD is great but it takes time that I usually do not have to commit 😂
|
wooo, thanks @ericadamski! |
Fixes #36, #43
Logic now filters out any types that overlap in the conversion types and the files to covert