Enhance error handling and progress reporting in database operations#1484
Draft
Stelinkaa wants to merge 5 commits into
Draft
Enhance error handling and progress reporting in database operations#1484Stelinkaa wants to merge 5 commits into
Stelinkaa wants to merge 5 commits into
Conversation
Collaborator
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9dd5b4170f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves robustness of import/export and query streaming by propagating failures more consistently, reporting progress/errors to the UI, and reducing resource retention during long-running operations.
Changes:
- Add backpressure-aware streaming and improved error propagation for MySQL
readQuerystreams. - Improve export UI error reporting by listening to
runner-infoand propagatingcopyStreamfailures as real errors. - Ensure Excel writer workbooks are released after writing to disk.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/dbgate-plugin-mysql/src/backend/drivers.js | Adds logging + backpressure handling to query-to-stream export path. |
| plugins/dbgate-plugin-excel/src/backend/writer.js | Clears cached workbooks after writing to avoid retaining them in memory. |
| packages/web/src/utility/exportFileTools.ts | Improves UI progress/error handling and passes structured progressName for hostConnection exports. |
| packages/api/src/shell/copyStream.js | Ensures copyStream errors propagate by rethrowing after emitting error/progress messages. |
| packages/api/src/proc/sessionProcess.js | Sends an error info message on reader failures and ensures writer closure happens once. |
| packages/api/src/proc/databaseConnectionProcess.js | Adds eval-json-script error reporting (but needs finalizer execution on error too). |
| packages/api/src/controllers/databaseConnections.js | Makes copyStreamError handling resilient to missing runid and emits runner progress error. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…prove reliability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.