porkbun: Add missing recap for 'ipv4/ipv6' and 'mtime'#885
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Porkbun protocol recap handling so ddclient’s cache reflects the current IP and modification time even when an update is skipped because the record is already correct.
Changes:
- In
nic_porkbun_update, recordipv4/ipv6andmtimein%recapboth when skipping (no change needed) and after a successful update. - Document the fix in
ChangeLog.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ddclient.in | Updates Porkbun NIC logic to always write ipv4/ipv6 and mtime into %recap when the current DNS content matches or after updating. |
| ChangeLog.md | Adds a changelog entry describing the Porkbun recap/mtime fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add missing recap for 'ipv4/ipv6' and 'mtime' in `nic_porkbun_update`. This is necessary to ensure that the cache is properly updated with the latest IP address and modification time.
Comment on lines
6895
to
6899
| if ($records->[0]{'content'} eq $ip) { | ||
| $recap{$h}{"ipv$ipv"} = $ip; | ||
| $recap{$h}{'mtime'} = $now; | ||
| $recap{$h}{"status-ipv$ipv"} = "good"; | ||
| success("skipped: IPv$ipv address was already set to $ip"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing recap for 'ipv4/ipv6' and 'mtime' in
nic_porkbun_update.This is necessary to ensure that the cache is properly updated with the latest IP address and modification time.