Skip to content

Visualise Map#13

Draft
surelook wants to merge 7 commits into
ddm999:mainfrom
surelook:feat/map
Draft

Visualise Map#13
surelook wants to merge 7 commits into
ddm999:mainfrom
surelook:feat/map

Conversation

@surelook

Copy link
Copy Markdown

No description provided.

@ddm999

ddm999 commented Oct 18, 2022

Copy link
Copy Markdown
Owner

Relates to #12

@ddm999 ddm999 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the effort so far! Gimme a shout if at any point you'd prefer me to take over work on this.

Comment thread MainWindow.xaml.cs Outdated
Comment thread MainWindow.xaml Outdated
</Viewbox>

</Grid>
</TabItem>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently I'm using spaces over tabs 😆

Comment thread MainWindow.xaml Outdated
Comment thread TrackData.cs
namespace ClubmanSharp
{
struct Segment
public struct Segment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this actually necessary?

Comment thread MainWindow.xaml Outdated
<TabItem Header="Map">
<Grid Background="#222">
<Viewbox>
<Canvas Name="MapCanvas" Width="2000" Height="2000" Background="LightGray">

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have any scaling artifacts due to the very large width/height?
Is there any better way of doing the scaling elsewhere?
(maybe don't set MapCanvas.Width & .Height and instead read them and modify the shapes drawn instead?)

Comment thread MainWindow.xaml Outdated
</TextBlock>
</Grid>
</TabItem>
<TabItem Header="Map">

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer this to be moved to the Race tab, but only made visible (over the top of the TextBlocks) when currentMenuState == Race

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants