fix(log): fix panic error when building app log message#139
Merged
Conversation
|
@jchauncey and @krancour are potential reviewers of this pull request based on my analysis of |
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
=========================================
+ Coverage 49.87% 50.5% +0.63%
=========================================
Files 13 13
Lines 391 396 +5
=========================================
+ Hits 195 200 +5
Misses 172 172
Partials 24 24
Continue to review full report at Codecov.
|
mboersma
approved these changes
Mar 22, 2017
jchauncey
approved these changes
Mar 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #136 by catching when the pod name fails the pod regex.