fix(*): build and run the server inside alpine:3.3 (WIP)#50
Closed
arschles wants to merge 4 commits into
Closed
Conversation
Member
Author
|
this is untested in production |
added 4 commits
February 4, 2016 16:46
can’t turn off CGO, but this is enough to get a minio server binary that can run in alpine, as long as DOCKERIMAGE is set to 1 in the environment in which it runs
instead of manually building with ‘go build’
8fd0401 to
e730b51
Compare
Member
Author
|
removing both LGTMs - current status of this PR is that the minio server fails to start with |
Member
Author
|
removing the |
Member
|
Just to note: deis/minio currently builds minio from source using commit SHA 356b889. When we previously had tried to move to an official release tag, we saw problems in testing and reverted. This was months ago, so it's probably worth revisiting updated minio releases and/or binary builds. |
Member
Author
|
@mboersma thanks for the context. I'm putting this on the v2 milestone so we can try again, and I'll rebase now |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8