ref(Makefile,manifests/*): use envtpl to render dev manifests#52
Closed
arschles wants to merge 1 commit into
Closed
ref(Makefile,manifests/*): use envtpl to render dev manifests#52arschles wants to merge 1 commit into
arschles wants to merge 1 commit into
Conversation
3a24b20 to
d70af2b
Compare
Member
Author
|
removing the |
Member
Author
|
closing this as #73 renders it obsolete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch changes k8s manifests into Go templates and uses envtpl to render them from the makefile. It then sends the rendered result directly into
kubectl create, which can accept manifests from STDIN.If maintainers like this style, we can apply it to other repos.