You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current minio master is not very stable and the release version of minio doesn't have the fix for multi-part upload.So we cloned the minio repo and cherrypicked the commit.
This PR is to use the deis version of the minio server.
This PR changes deis/minio to build from the "deis" branch of https://github.com/deis/minio-src, which is minio tag OFFICIAL.2016-02-08T00-12-28Z plus a multipart upload fix. I've tried the before/after tests several times and this does fix deploying example-ruby-sinatra. I've tested the other Deis example buildpack and Dockerfile apps with git push deis master too and had success.
This PR changes deis/minio to build from the "deis" branch of https://github.com/deis/minio-src, which is minio tag OFFICIAL.2016-02-08T00-12-28Z plus a multipart upload fix. I've tried the before/after tests several times and this does fix deploying example-ruby-sinatra. I've tested the other Deis example buildpack and Dockerfile apps with git push deis master too and had success.
—
Reply to this email directly or view it on GitHub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current minio master is not very stable and the release version of minio doesn't have the fix for multi-part upload.So we cloned the minio repo and cherrypicked the commit.
This PR is to use the deis version of the minio server.
Update by mboersma
Closes deis/workflow#367.