update(minio): update to minio server to master#81
Conversation
| mkdir -p $GOPATH/src/github.com/minio | ||
| cd $GOPATH/src/github.com/minio | ||
| git clone -b deis --single-branch https://github.com/deis/minio-src.git minio | ||
| git clone -b master --single-branch https://github.com/minio/minio.git minio |
There was a problem hiding this comment.
Rather than "master" which floats, it would be safer to build from a specific git commit SHA here.
There was a problem hiding this comment.
Minio people had said they are gonna make a release this weekend mostly... We can wait or we can rebase our Deis/minio-src branch to latest
There was a problem hiding this comment.
master will probably change many times over the next few days, so the contents of the deis/minio image could change depending on when someone builds it. That's not good for people testing or for CI, where we need reproducible builds.
I still think using a current SHA is safer. Then when minio actually has a new release tag we can test that code and switch to that.
There was a problem hiding this comment.
+1 here too. we built off master for alpha since our release was already a "moving target". now that we're solidified a bit, we should freeze the minio code that we release.
also, if/when Minio makes a release, it also would come in prebuilt binary form, so we could simply download and use it.
There was a problem hiding this comment.
made the change to use the current SHA
update(minio): update to minio server to master
Use the minio master branch to build the mino server. This is required as they have few fixes which are useful for registry to use minio as the backend.