feat(boot): allow minio host/port information to be configurable#82
Merged
Merged
Conversation
cec1e6a to
a108710
Compare
| } | ||
|
|
||
| func newMinioClient(host string, port int, accessKey, accessSecret string, insecure bool) (minio.CloudStorageClient, error) { | ||
| func newMinioClient(host string, port string, accessKey, accessSecret string, insecure bool) (minio.CloudStorageClient, error) { |
Member
There was a problem hiding this comment.
@bacongobbler you can now write this as host, port, accessKey, accessSecret string, insecure bool
Member
There was a problem hiding this comment.
the above doesn't need to block this PR, however
a108710 to
59db09f
Compare
59db09f to
f455e17
Compare
bacongobbler
pushed a commit
that referenced
this pull request
Mar 7, 2016
feat(boot): allow minio host/port information to be configurable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allows me to test certain changes like deis/postgres#62