Skip to content

fix(glide): add alias for speter.net/go/exp/math/dec/inf#97

Merged
vdice merged 1 commit into
deis:masterfrom
vdice:speter-fix
May 17, 2016
Merged

fix(glide): add alias for speter.net/go/exp/math/dec/inf#97
vdice merged 1 commit into
deis:masterfrom
vdice:speter-fix

Conversation

@vdice

@vdice vdice commented May 17, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

make docker-build was prev failing (see https://ci.deis.io/job/minio/7/console)

ref deis/workflow-manager#46

@vdice vdice added this to the v2.0-rc1 milestone May 17, 2016
@vdice vdice self-assigned this May 17, 2016
arschles
arschles reviewed May 17, 2016
View reviewed changes
Comment thread glide.lock
- proto
- name: github.com/google/cadvisor
version: a8085bf9276c22f16dbcd7aa56f0d4d0626a0b2e
version: aa6f80814bc6fdb43a0ed12719658225420ffb7d

@arschles arschles May 17, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change this back to the old version? same with the below k8s.io/kubernetes dep

@vdice vdice May 17, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arschles will do -- is there a glide update variant I should've used to only update this particular package (w/ added alias)?

@vdice vdice May 17, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now updated.

@arschles arschles May 17, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vdice not that I know of. I've done a bit of investigation on that, but haven't found anything.

cc/ @technosophos in case you know the answer to this question

@vdice

vdice commented May 17, 2016

Copy link
Copy Markdown
Member Author

@arschles unfortunately, when cadvisor and k8s versions are not updated, the build fails with https://travis-ci.org/deis/minio/builds/130946476 -- wondering what can we do to remedy?

@arschles

arschles commented May 17, 2016

Copy link
Copy Markdown
Member

ah, I see why. it looks like at least some of those changes were transitive dependency updates - sorry I missed that. if you let glide do all updates necessary (i.e. not do what I said), I'm guessing the build will pass?

@vdice

vdice commented May 17, 2016 •
edited
Loading

Copy link
Copy Markdown
Member Author

@arschles , I believe so. Just pushed a new glide.lock via glide update locally... waiting for ci to confirm...

@arschles

arschles commented May 17, 2016

Copy link
Copy Markdown
Member

@vdice sounds good. I've LGTM2-ed this PR, g2g when the build passes 👍

@vdice vdice merged commit dcca9e0 into deis:master May 17, 2016
@vdice vdice deleted the speter-fix branch May 17, 2016 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vdice vdice

Labels

easy fix LGTM1 LGTM2

Projects

None yet

Milestone

v2.0-rc1

Development

Successfully merging this pull request may close these issues.

3 participants

@vdice @arschles @bacongobbler