Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

ref(ci): rm travis and unused scripts#803

Merged
vdice merged 1 commit into
deis:masterfrom
vdice:ref/rm-travis
Apr 28, 2017
Merged

ref(ci): rm travis and unused scripts#803
vdice merged 1 commit into
deis:masterfrom
vdice:ref/rm-travis

Conversation

@vdice

@vdice vdice commented Apr 28, 2017

Copy link
Copy Markdown
Member

Re: removing Travis, Jenkins handles CI around building and testing the docker image via the workflow-docs job. See also the job configuration

@vdice vdice added this to the v2.14 milestone Apr 28, 2017
@vdice vdice self-assigned this Apr 28, 2017
@vdice vdice requested review from mboersma and slack April 28, 2017 17:01
@bacongobbler

Copy link
Copy Markdown
Member

yep, make docker-build docker-test should cover all the steps Travis currently does. 👍

@bacongobbler

Copy link
Copy Markdown
Member

Isn't the gutenbuild script still needed for the deis.com job though, or is the docs deployed a different way now?

@vdice

vdice commented Apr 28, 2017

Copy link
Copy Markdown
Member Author

Isn't the gutenbuild script still needed for the deis.com job though, or is the docs deployed a different way now?

Great question; hoping to get clarity from @slack or @ultimateboy on this detail.

@ultimateboy

Copy link
Copy Markdown
Member

That script is used by gutenberg: https://github.com/deis/gutenberg/blob/master/script/compile#L26

@vdice

vdice commented Apr 28, 2017

Copy link
Copy Markdown
Member Author

Thanks @ultimateboy -- _scripts/gutenbuild added back/not deleted. Could I get your blessing before merging?

@bacongobbler

Copy link
Copy Markdown
Member

Looks good to me.

@vdice vdice merged commit 8526e49 into deis:master Apr 28, 2017
@vdice vdice deleted the ref/rm-travis branch April 28, 2017 20:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants