Skip to content

Fix wwm matching failure on NVMe mounts #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2024
Merged

Fix wwm matching failure on NVMe mounts #328

merged 1 commit into from
Sep 20, 2024

Conversation

@suryagupta4
Copy link
Contributor

@suryagupta4 suryagupta4 commented Sep 20, 2024 •
edited
Loading

Description

Update to the PowerStore driver to use the gobrick with the NVMe matching fix for issue 1469. This issue prevents successful mounting of PowerStore devices when using the NVMe protocols.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1469

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

donatwork
donatwork approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@donatwork donatwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged into main. Thanks.

@suryagupta4 suryagupta4 marked this pull request as ready for review September 20, 2024 09:52
@gallacher gallacher merged commit 45e176a into main Sep 20, 2024
5 checks passed
@gallacher gallacher deleted the 1469_nvme_wwn_matching branch September 20, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

3 more reviewers

@donatwork donatwork donatwork approved these changes

@gallacher gallacher gallacher approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@suryagupta4 @donatwork @gallacher @AkshaySainiDell