Skip to content

Get SymID from configmap if secret doesnt exist #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2025
Merged

Get SymID from configmap if secret doesnt exist #501

merged 3 commits into from
Mar 28, 2025

Conversation

@kumarkgosa
Copy link
Contributor

@kumarkgosa kumarkgosa commented Mar 27, 2025

Description

Get the SymIDs from reverse-proxy configmap instead when secret doesnt contain managed arrays.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1707

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Ran UT to make sure the SymIds are populated. Verified fix with new image and testing if HostIDs are creating and it was.
This is with Nightly image : Nodehostsetup starts and stops as it couldnt find SymIds
image
This is a test image with this fix :
image
image

donatwork
donatwork reviewed Mar 27, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powermax/service 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powermax/service/node.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

donatwork
donatwork approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@donatwork donatwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have been cleaner to encapsulate. I have pending changes coming up close to this code so will look into it.

@kumarkgosa kumarkgosa merged commit 0a0a28b into main Mar 28, 2025
6 checks passed
@kumarkgosa kumarkgosa deleted the usr/kgosa/fix-symid branch March 28, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

4 more reviewers

@donatwork donatwork donatwork approved these changes

@alikdell alikdell alikdell approved these changes

@EvgenyUglov EvgenyUglov EvgenyUglov approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kumarkgosa @donatwork @alikdell @EvgenyUglov @AkshaySainiDell