Driver restart mount fix #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and additional changes to remove /noderoot mounts in unPublishVolume and unmountPrivVolume.
…o outline to scenario.
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
donatwork
reviewed
Apr 15, 2025
Comment on lines
+512
to
517
| for _, t := range tgtMnt { | ||
| log.WithFields(f).Debugf("Unmounting %s", t) | ||
| if err := gofsutil.Unmount(ctx, t); err != nil { | ||
| return lastUnmounted, status.Errorf(codes.Internal, | ||
| "Error unmounting target: %s", err.Error()) | ||
| } |
There was a problem hiding this comment.
Is this the correct behavior when an error is encountered. If there are other mounts that need to be unmounted then what will the state of the node be?
There was a problem hiding this comment.
In this change we're looking for /noderoot prefixed mounts, not errors, so only these additional mounts are unmounted. So far on driver restart we've seen dupMounts with "/noderoot" prefix as on line 473.
donatwork
approved these changes
Apr 15, 2025
alikdell
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjust the driver node behaviour to remove extra mount points that materialize on a driver restart.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
op e2e ran, results tracked internally