NetworkError caused by WebSocketStream cannot be caught? #22165

Activity

1. kt3k commented on Jan 29, 2024

   

   kt3k

   on Jan 29, 2024

   Contributor

   More actions

   It looks like you also need to await ws.closed to avoid uncaught error:

    const listener = Deno.listen({ port: 9000, transport: "tcp" });
   
    try {
       for await (const conn of listener) {
           (async () => {
               const ws = new WebSocketStream("ws://loca99999999999lhost:8000", {
                   headers: {
                       "x-Protocol": "Transmission Control",
                       "X-Destination-Address": "www.ba99999999999idu.com",
                       "X-Destination-Port": "80",
                   },
               });
               // console.log(ws);
               try {
                   const webConn = await ws.opened; //.catch(console.error);
                   // console.log(webConn);
                   conn.readable.pipeTo(webConn.writable).catch(function (e) {
                       try {
                           ws.close();
                           conn.close();
                       } catch (e) {
                           console.error(e);
                       }
   
                       return console.error(e);
                   });
                   webConn.readable.pipeTo(conn.writable).catch(function (e) {
                       try {
                           ws.close();
                           conn.close();
                       } catch (e) {
                           console.error(e);
                       }
                       return console.error(e);
                   });
               } catch (error) {
                   console.error(error);
                   try {
                       ws.close();
                       conn.close();
   +                   await ws.closed;
                   } catch (e) {
                       console.error(e);
                   }
               }
           })().catch(console.error);
       }
    } catch (error) {
       console.error(error);
    }
2. masx200 commented on Jan 29, 2024

   

   masx200

   on Jan 29, 2024

   Author

   More actions

   While this can be solved, can we design a better WebSocketStream api?
   It's too hard to use
3. masx200 commented on Jan 29, 2024

   

   masx200

   on Jan 29, 2024

   Author

   More actions

   export class WebSocketStream {
       public socket: WebSocket;
       public readable: ReadableStream<Uint8Array>;
       public writable: WritableStream<Uint8Array>;
   
       constructor(socket: WebSocket) {
           this.socket = socket;
           this.readable = new ReadableStream({
               start(controller) {
                   socket.onmessage = function ({ data }) {
                       // console.log(data);
                       return controller.enqueue(new Uint8Array(data));
                   };
                   socket.onerror = (e) => controller.error(e);
                   socket.onclose = (/* e */) => controller.close(/* e */);
               },
               cancel(/* reason */) {
                   socket.close();
               },
           });
           this.writable = new WritableStream({
               start(controller) {
                   socket.onerror = (e) => controller.error(e);
               },
               write(chunk) {
                   // console.log(chunk);
                   socket.send(chunk);
               },
               close() {
                   socket.close();
               },
               abort(e) {
                   console.error(e);
                   socket.close();
               },
           });
       }
   }
4. kt3k commented on Jan 29, 2024

   

   kt3k

   on Jan 29, 2024

   Contributor

   More actions

   WebSocketStream is designed based on Web Standard proposal whatwg/websockets#48 It's not a good idea to design it in our own way.

   ref: #8831
5. kt3k commented on Jan 30, 2024

   

   kt3k

   on Jan 30, 2024

   Contributor

   More actions

   Closing as the original issue is solved and nothing is actionable further.

   While this can be solved, can we design a better WebSocketStream api?
   It's too hard to use

   You are encouraged to create 3rd party module to address those pain points
6. kt3k

   closed this as completedon Jan 30, 2024