chore: Update --text for improved contrast
#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
srry for the format error. it must be a github bug because my code isn't like that |
MaximilianHeidenreich
approved these changes
Oct 23, 2025
There was a problem hiding this comment.
@deeivihh PR looks good, but the commits need to be signed-off. Please referr to https://github.com/deta/surf?tab=contributing-ov-file#3-commit-with-signed-off-by if you need more info :)
--text for improved contrast--text for improved contrast
…rast Signed-off-by: deeivihh <deeivihh@hotmail.com>
Signed-off-by: deeivihh <deeivihh@hotmail.com>
|
All set! |
aavshr
approved these changes
Oct 23, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small pull request solves the problem discussed in this discord thread, where the text in dark mode has very little contrast.
I added the light-dark function and set the text color for dark mode to
#ddd6d0(based on packages/teletype/app.scss .dark) to improve the contrast.before
after