Skip to content

UselessPostfixExpression - Fix #7037 false positive postfix#7084

Merged
BraisGabin merged 1 commit into
detekt:mainfrom
psuzn:postfix-false-positive
Mar 24, 2024
Merged

UselessPostfixExpression - Fix #7037 false positive postfix#7084
BraisGabin merged 1 commit into
detekt:mainfrom
psuzn:postfix-false-positive

Conversation

@psuzn

@psuzn psuzn commented Mar 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix for #7037

@psuzn psuzn marked this pull request as ready for review March 24, 2024 06:26
@codecov

codecov Bot commented Mar 24, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.67%. Comparing base (51b988a) to head (3126a04).

Files Patch % Lines
...osch/detekt/rules/bugs/UselessPostfixExpression.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #7084   +/-   ##
=========================================
  Coverage     83.67%   83.67%           
  Complexity     3957     3957           
=========================================
  Files           578      578           
  Lines         12169    12170    +1     
  Branches       2516     2516           
=========================================
+ Hits          10182    10183    +1     
  Misses          731      731           
  Partials       1256     1256

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psuzn psuzn force-pushed the postfix-false-positive branch from 02dc979 to fd54b1a Compare March 24, 2024 06:36
@psuzn psuzn force-pushed the postfix-false-positive branch from fd54b1a to 3126a04 Compare March 24, 2024 06:45
@cortinico cortinico added the pick request Marker for PRs that should be ported to the 1.0 release branch label Mar 24, 2024
@cortinico cortinico changed the title fix #7037 : false positive postfix UselessPostfixExpression.kt - Fix #7037 false positive postfix Mar 24, 2024
@cortinico cortinico changed the title UselessPostfixExpression.kt - Fix #7037 false positive postfix UselessPostfixExpression - Fix #7037 false positive postfix Mar 24, 2024
@cortinico cortinico mentioned this pull request Mar 24, 2024
Merged
@BraisGabin BraisGabin merged commit b1c3dc2 into detekt:main Mar 24, 2024
@detekt-ci

detekt-ci commented Mar 24, 2024

Copy link
Copy Markdown
Collaborator
Warnings
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

Generated by 🚫 dangerJS against 3126a04

@cortinico cortinico added this to the 2.0.0 milestone Mar 24, 2024
cortinico pushed a commit that referenced this pull request Mar 24, 2024
@psuzn @cortinico
fix for false positive postfix (#7084)
d9bce89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BraisGabin BraisGabin BraisGabin approved these changes

@cortinico cortinico cortinico approved these changes

@schalkms schalkms schalkms approved these changes

Assignees

No one assigned

Labels

pick request Marker for PRs that should be ported to the 1.0 release branch rules

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@psuzn @detekt-ci @BraisGabin @cortinico @schalkms