Check for public companion object for UndocumentedPublicClass#7219
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7219 +/- ##
============================================
+ Coverage 84.70% 84.71% +0.01%
- Complexity 3983 3986 +3
============================================
Files 578 578
Lines 12151 12156 +5
Branches 2495 2498 +3
============================================
+ Hits 10292 10298 +6
Misses 625 625
+ Partials 1234 1233 -1 ☔ View full report in Codecov by Sentry. |
BraisGabin
approved these changes
Apr 26, 2024
Collaborator
cortinico
pushed a commit
that referenced
this pull request
Aug 29, 2024
Nava2
added a commit
to Nava2/detekt
that referenced
this pull request
Sep 13, 2024
…g `companion object` without name Closes detekt#7634 in favour of leaving the rule as described with configuration to disable to pre-detekt#7219 value.
BraisGabin
pushed a commit
that referenced
this pull request
Oct 19, 2024
#7635) * Issue #7634: Make `UndocumentedPublicClass` configurable to flag `companion object` without name Closes #7634 in favour of leaving the rule as described with configuration to disable to pre-#7219 value. * fix detekt violations * fix name * address naming comments, add new test * lint * address comments, add more tests for edge case * remove text look-up, replace with nameIdentifier check * detekt * fix compilation for examples
cortinico
pushed a commit
that referenced
this pull request
Jan 17, 2025
#7635) * Issue #7634: Make `UndocumentedPublicClass` configurable to flag `companion object` without name Closes #7634 in favour of leaving the rule as described with configuration to disable to pre-#7219 value. * fix detekt violations * fix name * address naming comments, add new test * lint * address comments, add more tests for edge case * remove text look-up, replace with nameIdentifier check * detekt * fix compilation for examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7217