Remove "V2" from DGP plugin display name and description#8628
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8628 +/- ##
=========================================
Coverage 86.18% 86.18%
Complexity 4384 4384
=========================================
Files 569 569
Lines 13858 13858
Branches 2605 2605
=========================================
Hits 11944 11944
Misses 780 780
Partials 1134 1134 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| id = "dev.detekt" | ||
| displayName = "Static code analysis for Kotlin v2" | ||
| description = "Static code analysis for Kotlin v2" | ||
| displayName = "Static code analysis for Kotlin" |
There was a problem hiding this comment.
This won't work as it will clash with https://plugins.gradle.org/plugin/io.gitlab.arturbosch.detekt
so needs to be reworded
There was a problem hiding this comment.
Is it the display name, the description, or both that cannot conflict with a previously published version?
And I think only description is shown in the plugin portal, display name isn't.
There was a problem hiding this comment.
Only the description needs to be unique:
We received your plugin submissions of "dev.detekt.gradle.base", "dev.detekt.gradle.compiler-plugin", "dev.detekt" for "dev.detekt" group.
Your plugins were flagged for manual review because of the following issue(s):
Found 2 plugins with same description. Some of those plugin ids: dev.detekt.gradle.compiler-plugin, io.gitlab.arturbosch.detekt
Found 3 plugins with same description. Some of those plugin ids: dev.detekt.gradle.base, dev.detekt.gradle.compiler-plugin, io.gitlab.arturbosch.detekt
Please refer to our documentation on plugin approval guidelines for more information: https://plugins.gradle.org/docs/publish-plugin#approval
This is sadly not mentioned anywhere on their website, other than in those emails
There was a problem hiding this comment.
So was it ultimately rejected? Or was it just flagged for a review, and we're now waiting on a response?
There was a problem hiding this comment.
I've forwarded the latest email from the Gradle portal team in the maintainers mailing list, but I'm still waiting for a response from them
There was a problem hiding this comment.
So it's been published, with the V2 suffix...
Will publishing a new version without the suffix work or do you now have to go through a whole new manual review cycle?
There was a problem hiding this comment.
So it's been published, with the V2 suffix...
Yes because this is sadly the byproduct of:
(i.e. I need to publish locally from my machine and send a PR afterwards which I really dislike, because the CI would fail otherwise attempting to fetch artifacts that are not existing from Maven Central).
Will publishing a new version without the suffix work or do you now have to go through a whole new manual review cycle?
I can ask Gradle to update the descriptions of all of those manually probably. Not sure if we publish alpha.1 with the updated descriptions if that will reflect or not.
Need to confirm the description & displayName which is subject to constraints imposed by Gradle Inc
|
Marked as blocked till we understand how to remove those v2 suffixes. Publishing is unblocked at least |
|
This can be merged now, I've asked for the "V2" to be removed |
Follow up #8627
Cc @cortinico @BraisGabin