Fix invalid Maven POM metadata for ktlint-repackage #8824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove skip() configurations for apiElements and runtimeElements variants to allow proper dependency publishing. Without this, the published POM was empty, causing Maven consumers to miss ktlint transitive dependencies. The skip() configurations prevented the module's dependencies from being included in the generated POM file, breaking Maven-based projects that depend on detekt-rules-ktlint-wrapper. Fixes detekt#8626.
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8824 +/- ##
=========================================
Coverage 85.38% 85.38%
Complexity 4376 4376
=========================================
Files 569 569
Lines 12517 12517
Branches 2604 2604
=========================================
Hits 10688 10688
Misses 693 693
Partials 1136 1136 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Hi @Nava2 shouldn't same fix will go for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change added in #8292.
Remove skip() configurations for apiElements and runtimeElements variants to allow proper dependency publishing. Without this, the published POM was empty, causing Maven consumers to miss ktlint transitive dependencies.
The skip() configurations prevented the module's dependencies from being included in the generated POM file, breaking Maven-based projects that depend on detekt-rules-ktlint-wrapper.
Fixes #8626.